Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclosed "{if}", when it is actually closed #396

Closed
Stadly opened this issue Oct 16, 2017 · 1 comment
Closed

Unclosed "{if}", when it is actually closed #396

Stadly opened this issue Oct 16, 2017 · 1 comment

Comments

@Stadly
Copy link

Stadly commented Oct 16, 2017

The latest version of the master branch causes the template

{"{if true}foo{/if}"}

to throw a compiler exception: "{"{if true}foo{/if}"}" unclosed "{if}" in doubled quoted string.

This is probably due to the changes concerning #391 and #392, but in my opinion {"{if true}foo{/if}"} should be a valid template, even though {"{if true}"|cat:"foo{/if}"} should not.
uwetews added a commit to smarty-php/smarty-phpunit that referenced this issue Oct 18, 2017
@uwetews
update tests to cover
8beca79 
     smarty-php/smarty#396 smarty-php/smarty#397
    smarty-php/smarty#391 smarty-php/smarty#392
uwetews added a commit that referenced this issue Oct 18, 2017
@uwetews
-bugfix fix implementation of unclosed block tag in double quoted str…
e4f41ad 
…ing of 12.10.2017

    #396 #397
    #391 #392
@uwetews
Copy link
Contributor

uwetews commented Oct 18, 2017

This is now fixed.

@uwetews uwetews closed this as completed Oct 18, 2017
wisskid pushed a commit that referenced this issue Apr 12, 2020
@uwetews
update tests to cover
37288b4 
     #396 #397
    #391 #392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uwetews @Stadly