Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier is applied on whole expression (3.1.32) #491

Closed
getdatakick opened this issue Sep 20, 2018 · 2 comments
Closed

Modifier is applied on whole expression (3.1.32) #491

getdatakick opened this issue Sep 20, 2018 · 2 comments

Comments

@getdatakick
Copy link

Since smarty 3.1.32 the modifier is applied on whole expression:

{1 + array(1, 2, 3)|count}

The result of this expression used to be 4. Now it tries to apply count function on the result of 1+array(1,2,3), which throws Fatal error: Unsupported operand types on php 7.2.

@Pharaoh2k
Copy link

Seems to be still the case on 3.1.33

uwetews added a commit to smarty-php/smarty-phpunit that referenced this issue Oct 9, 2018
uwetews added a commit that referenced this issue Oct 9, 2018
 - bugfix fix of 26.8.2017 #327
   modifier is applied to sum expression #491
 - bugfix indexed arrays could not be defined "array(...)""
uwetews added a commit that referenced this issue Oct 9, 2018
 - bugfix fix of 26.8.2017 #327
   modifier is applied to sum expression #491
 - bugfix indexed arrays could not be defined "array(...)""
@uwetews
Copy link
Contributor

uwetews commented Oct 9, 2018

The fix is now in the master branch and will later be included in 3.1.34

@uwetews uwetews closed this as completed Oct 9, 2018
Traumflug added a commit to thirtybees/thirtybees that referenced this issue May 9, 2019
This should solve all warnings coming with PHP 7.2 and PHP 7.3.

Not to the latest 3.1.33 because of this bug:
smarty-php/smarty#491
This bug should be fixed with the next release, 3.1.34.

3.1.19 was from October 2014, 4.5 years old.
Traumflug added a commit to thirtybees/thirtybees that referenced this issue May 10, 2019
This should solve all warnings coming with PHP 7.2 and PHP 7.3.

Not to the latest 3.1.33 because of this bug:
smarty-php/smarty#491
This bug should be fixed with the next release, 3.1.34.

3.1.19 was from October 2014, 4.5 years old.
Traumflug added a commit to thirtybees/thirtybees that referenced this issue May 23, 2019
This should solve all warnings coming with PHP 7.2 and PHP 7.3.

Not to the latest 3.1.33 because of this bug:
smarty-php/smarty#491
This bug should be fixed with the next release, 3.1.34.

3.1.19 was from October 2014, 4.5 years old.
Traumflug added a commit to thirtybees/thirtybees that referenced this issue Jun 15, 2019
This should solve all warnings coming with PHP 7.2 and PHP 7.3.

Not to the latest 3.1.33 because of this bug:
smarty-php/smarty#491
This bug should be fixed with the next release, 3.1.34.

3.1.19 was from October 2014, 4.5 years old.
Traumflug added a commit to thirtybees/thirtybees that referenced this issue Jun 18, 2019
This should solve all warnings coming with PHP 7.2 and PHP 7.3.

Not to the latest 3.1.33 because of this bug:
smarty-php/smarty#491
This bug should be fixed with the next release, 3.1.34.

3.1.19 was from October 2014, 4.5 years old.
Traumflug added a commit to thirtybees/thirtybees that referenced this issue Jun 23, 2019
This should solve all warnings coming with PHP 7.2 and PHP 7.3.

Not to the latest 3.1.33 because of this bug:
smarty-php/smarty#491
This bug should be fixed with the next release, 3.1.34.

3.1.19 was from October 2014, 4.5 years old.
wisskid pushed a commit that referenced this issue Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants