Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Smarty autoloading. #252

Closed
wants to merge 5 commits into from
Closed

Conversation

@AnrDaemon
Copy link
Contributor

AnrDaemon commented Jun 28, 2016

  • Privatize Autoloader class properties.
    There MUST NOT be the use case, need or reason to change them,
    not at runtime, and not from outside the class itself.
  • Move *Exception classes to SMARTY_DIR.
    Placing them in sysplugins was, IMO, a mistake.
  • Remove now-redundant string comparisons.
    The class is either base (registered in the array and located in the SMARTY_DIR),
    or it is a sysplugin named after "smarty_", so there's no need to check for "smarty" twice.
AnrDaemon added 3 commits Jun 28, 2016
  There must be no use case, need or reason to change them,
  especially not outside of the class, and never at runtime.
@AnrDaemon

This comment has been minimized.

Copy link
Contributor Author

AnrDaemon commented Jun 28, 2016

I wanted to avoid moving files, but it seems there's no way around it.
SMARTY_SYSPLUGINS_DIR could be redefined before autoloader is registered.

@uwetews uwetews force-pushed the smarty-php:master branch 17 times, most recently from 471797c to 64ed85a Oct 9, 2017
@AnrDaemon AnrDaemon closed this Dec 5, 2017
@AnrDaemon AnrDaemon deleted the AnrDaemon:privatization branch Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.