Improve Smarty autoloading. #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 28, 2016 08:32
There must be no use case, need or reason to change them, especially not outside of the class, and never at runtime.
|
I wanted to avoid moving files, but it seems there's no way around it. |
uwetews
force-pushed
the
master
branch
17 times, most recently
from
471797c
to
64ed85a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There MUST NOT be the use case, need or reason to change them,
not at runtime, and not from outside the class itself.
Placing them in sysplugins was, IMO, a mistake.
The class is either base (registered in the array and located in the SMARTY_DIR),
or it is a sysplugin named after "smarty_", so there's no need to check for "smarty" twice.