Fix error handler allowUndefinedVars #735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapics
reviewed
Feb 28, 2022
| @@ -66,7 +66,7 @@ public function deactivate() { | |||
| */ | |||
| public function handleError($errno, $errstr, $errfile, $errline, $errcontext = []) | |||
| { | |||
| if ($this->allowUndefinedVars && $errstr == 'Attempt to read property "value" on null') { | |||
| if ($this->allowUndefinedVars && preg_match('/^Attempt to read property ".+?" on null$/', $errstr)) { | |||
There was a problem hiding this comment.
I want to use \w instead of ., when we need to catch alphanumeric case.
There was a problem hiding this comment.
Properties can also include - and maybe even : etc, so it uneagerly matches to the first ". https://3v4l.org/s9KPc
|
This pull request would make it possible to migrate to newer version without a large amount of changes. Could this be merged? |
|
Does nobody have |
|
This change seems straightforward. Should be able to merge this. Just to be clear: could you provide an exact issue? I.e. what problem does this solve? |
That would trigger a
I'll fix the merge conflict. |
|
I propose a slightly different implementation, see #832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleErroronly checks for propertyvalue, which is odd. I'm getting errorBecause
idis the property being accessed. So it should check for any property name, not justvalue.