Bugfix/rand without param v3 #796
Conversation
| @@ -27,7 +27,7 @@ | |||
| "forum": "http://www.smarty.net/forums/" | |||
| }, | |||
| "require": { | |||
| "php": ">=5.2" | |||
| "php": "^5.2 || ^7.0" | |||
There was a problem hiding this comment.
@wisskid Hey, I had been using smarty 3.1.x with PHP 8. Just want to confirm that this was intended - not compatible with 8?
I was actually using it indirectly through the Widgets extension for MediaWiki, which requires smarty 3.1.x. But I ran into a problem trying to install it in a mediawiki:1.39.2 Docker container recently (which uses PHP 8), since the Widgets extension had bumped their smarty requirement to 1.3.47 to get a recent security fix, which brought along this change.
(see wikimedia/mediawiki-extensions-Widgets@a13445f#r102066674)
There was a problem hiding this comment.
Yes, PHP8 support has been added in smarty v4. It should be a relatively cheap upgrade.
There was a problem hiding this comment.
And Smarty 5 is in development 👍
#852
There was a problem hiding this comment.
Alright, thanks guys. Now I actually saw that the MediaWiki Widget extensions folks moved back to 3.1.46 in their master branch due to this, I guess until they've ensured it'll work with 4.x (wikimedia/mediawiki-extensions-Widgets@2022ef9). (I was using their REL_1_39 branch).
There was a problem hiding this comment.
I can see why they do this, but in reality the 3.1.46 version is of course no more php8 compatible than 3.1.47 is.
There was a problem hiding this comment.
Hi, yes. The 3.1.46 thing we did is just super temporary until we can update to 4, which we (mediawiki widgets extension) intend to do in short order once we fix our incompatibilities with 4.x
No description provided.