releases are not compatible with "go mod"

[marcofranssen]

new go 11 mod feature does not support version which do not have the v prefix on version numbers.

So far I did not find a way to install goconvey using go mod

module github.com/marcofranssen/myproject

require github.com/smartystreets/goconvey/convey 1.6.3

In general other packages I depend on do work.

module github.com/marcofranssen/myproject

require github.com/goreleaser/goreleaser v0.93.2

As you can see this package contians the v prefix. in the version number.

[amalhanaja]

did you changed your go.mod file ?
I'm use this commands every add pacakges
go get -u <package> inside my work dir, it's inserted new line on my go.mod files

[nasermirzaei89]

I used:

go get -u github.com/smartystreets/goconvey

but added this line to my go.mod

github.com/smartystreets/assertions v0.0.0-20190215210624-980c5ac6f3ac // indirect

[vilakshminar]

I'm having the same issue. I think all the tags generated need to be prefixed with a v or else go mod will automatically replace the 1.6.3 with the commit hash in both the go.mod & go.sum files.

It does work as it pulls the right commit but would be nice to make sure that go.mod has the version and not the commit.

[jpreese]

Was just going to ask the same thing. Would be nice if future tags could be prefixed with v for go mod support.

[marcofranssen]

Why not just tag the existing releases also with a go.mod compatible tag? Should be doable imho.

…

On Mon, Oct 28, 2019 at 9:13 PM John Reese ***@***.***> wrote: Was just going to ask the same thing. Would be nice if future tags could be prefixed with v for go mod support. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#551?email_source=notifications&email_token=AAFJTTOP36D55MOXYDVJKGLQQ5BU3A5CNFSM4GG5LX32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECOHPKQ#issuecomment-547125162>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFJTTMLZKKA2G2TOVC5NIDQQ5BU3ANCNFSM4GG5LX3Q> .

[jpreese]

Agreed, that also works if the maintainers want to take that approach.

[nasermirzaei89]

no reply after 1 year from owners or maintainers. a library with more than 5k stars is more like a stale repository!!!

[jpreese]

There was a merge a few months ago, maybe they just got busy with other priorities :)

@riannucci do you have any thoughts on this?

[riannucci]

Hi!

(Sorry for not being more proactive maintainer-wise; I haven't gotten to do any development on goconvey for years now 😢)

If I understand correctly... All we need to do is to add vXXX tags for each XXX tag and go.mod should be happy with it?

Pretty sure I can do that... let me give it a shot.

R

[jpreese]

That's correct! The Go toolchain for modules explicitly looks for a vX.Y.Z tag when trying to resolve the latest version for a given repository.

[riannucci]

Okey dokey, I've created v versions of all existing tags. I'm going to try to create a new release as well, since it looks like the last one is pretty old.

[riannucci]

Alright, I've posted a v1.6.4 release as well, which contains everything currently on master.

[jpreese]

Awesome! Thanks so much

[riannucci]

Sorry for not doing this sooner!

Let me know if you run into any issues though, and I'll be happy to help get them landed.

One of these days I'll find some time to breathe some new life into goconvey...

[riannucci]

(marking this closed; please reopen if something's not working as expected)