Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many error classes aren't likely to succeed when you try again and so they probably shouldn't be retried by default.
Errors I don't think will typically work if retried:
Errors which may work if retried:
This is based on the errors handled by
StatusCodeSender
, as you can see it groups neatly into 400 errors (client errors) and 500 errors (server errors).This PR only retries anything less than 500.
Depending on your API compatibility stance this could be a big backwards compatibility change but it's in line with typical usage of HTTP.