Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/fix vagrant #38

Merged
merged 4 commits into from Jan 28, 2015
Merged

Chore/fix vagrant #38

merged 4 commits into from Jan 28, 2015

Conversation

@leonelgalan
Copy link
Contributor

@leonelgalan leonelgalan commented Jan 27, 2015

Again, this comes form my experience running setting up the new tape on weaveup.

  • No need for external provisioner file, it’s easier to do inline and
    it doesn’t depend on TAPE_PATH being set. This allows to use normal
    vagrant commands (e.g. vagrant up) rather than tape vagrant create.
  • We no longer need the ENV[‘TAPE_PATH’] that was used in the
    Vagrantfile. It was set in two places but not used elsewhere.
  • No need to set a specify IP, localhost (:private_network) works just
    fine.
  • No need to specify box url if full name is used: hashicorp/precise64.
leonelgalan added 4 commits Jan 26, 2015
 - No need for external provisioner file, it’s easier to do inline and
it doesn’t depend on TAPE_PATH being set. This allows to use normal
vagrant commands (e.g. `vagrant up`) rather than `tape vagrant create`.
-  We no longer need the ENV[‘TAPE_PATH’] that was used in the
`Vagrantfile`. It was set in two places but not used elsewhere.
- No need to set a specify IP, localhost (:private_network) works just
fine.
- No need to specify box url if full name is used: hashicorp/precise64.
BrandonMathis added a commit that referenced this pull request Jan 28, 2015
@BrandonMathis BrandonMathis merged commit 5bf7477 into master Jan 28, 2015
@leonelgalan leonelgalan deleted the chore/fix_vagrant branch Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants