Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing metrical concerns in JAMS annotations #99

Open
jonnybluesman opened this issue Dec 13, 2022 · 0 comments
Open

Addressing metrical concerns in JAMS annotations #99

jonnybluesman opened this issue Dec 13, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request high-priority jams-x Feature to be move to JAMS-X parser Related to ChoCo parsers

Comments

@jonnybluesman
Copy link
Member

Main problem

Users currently need to reference and use the original score / symbolic content to fully make sense of the annotations. This happens every time users need to manipulate metrical content in the symbolic partitions. Also, starting times are not consistent, as some of them use 0 as initial measure / beat number.

Affected partitions

Schubert Winterreise, Real Book, Wikifonia, iReal Pro, BiaB, When in Rome, Rock Corpus, Mozart Piano Sonata, Jazz Corpus, Nottingham

Related issues: #53 #52

Proposed solution

Addressing this issue requires a number of interventions, including the following.

  • Measure and beat onsets should always start from 1;
  • A new namespace is introduced for time signature (wrapping also changes);
  • For now, until we will start working on JAMS Score / JAMS X, durations are always encoded in beats (and not quarter beats).

Additional related tasks

  • Bug-check and fix on the iReal Pro partition (key starting from measure 1);
  • Include missing metadata.
@jonnybluesman jonnybluesman added enhancement New feature or request parser Related to ChoCo parsers high-priority labels Dec 13, 2022
@jonnybluesman jonnybluesman self-assigned this Dec 13, 2022
@jonnybluesman jonnybluesman added the jams-x Feature to be move to JAMS-X label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-priority jams-x Feature to be move to JAMS-X parser Related to ChoCo parsers
Projects
None yet
Development

No branches or pull requests

1 participant