update test to match firefox 124 behavior, set node to 21 to ci

smastrom · Apr 8, 2024 · 57e65cd · 57e65cd
1 parent 40211f5
commit 57e65cd
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/chrome-tests.yml b/.github/workflows/chrome-tests.yml
@@ -11,7 +11,7 @@ jobs:
          - uses: actions/checkout@v3
          - uses: actions/setup-node@v3
            with:
-              node-version: 20
+              node-version: 21
          - uses: pnpm/action-setup@v2
            name: Install pnpm
            with:

diff --git a/.github/workflows/firefox-tests.yml b/.github/workflows/firefox-tests.yml
@@ -11,7 +11,7 @@ jobs:
          - uses: actions/checkout@v3
          - uses: actions/setup-node@v3
            with:
-              node-version: 20
+              node-version: 21
          - uses: pnpm/action-setup@v2
            name: Install pnpm
            with:

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -20,7 +20,7 @@ jobs:
          - uses: actions/checkout@v3
          - uses: actions/setup-node@v3
            with:
-              node-version: '20.x'
+              node-version: '21.x'
               registry-url: 'https://registry.npmjs.org'
          - uses: pnpm/action-setup@v2
            name: Install pnpm

diff --git a/packages/vue-collapsed/tests/Collapse.cy.ts b/packages/vue-collapsed/tests/Collapse.cy.ts
@@ -275,10 +275,14 @@ describe('With baseHeight > 0', () => {
 
       cy.get('#TriggerButton').click()
 
+      const transition = 'height 0.3s cubic-bezier(0.33, 1, 0.68, 1)'
+
       cy.get('#Collapse').should(
          'have.css',
          'transition',
-         'height 0.3s cubic-bezier(0.33, 1, 0.68, 1) 0s'
+         isFirefox
+            ? transition // Firefox >= 124 doesn't include '0s' by default anymore
+            : `${transition} 0s`
       )
 
       cy.get('#Collapse').and('have.attr', 'style').and('include', '--vc-auto-duration: 300ms')