Explicit use of bytes in serial communications. #552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update srbox plugin to explicitly use the bytes type when sending data or making comparison to received data, as is required for serial communications. Previously, the srbox plugin failed under Python 3 because the str type was being used without being encoded as bytes. The changes should not break compatibility with Python 2, where bytes == str.
|
Thanks! I haven't tested this, because I don't have an SRBox with me right now, but it seems like a straightforward and solid fix. Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update srbox plugin to explicitly use the bytes type when sending data or making comparison to received data, as is required for serial communications. Previously, the srbox plugin failed under Python 3 because the str type was being used without being encoded as bytes. The changes should not break compatibility with Python 2, where bytes == str.