Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing options to delete #60

Closed
wants to merge 9 commits into from

Conversation

tonnenpinguin
Copy link
Contributor

@tonnenpinguin tonnenpinguin commented Jul 19, 2019

In order to delete for example private images as well we need to be able to pass options to the delete function.

This PR implements this behaviour and can be used like so:

Cloudex.delete(public_id, %{resource_type: "image", type: "private"})

As returning the DeletedImage struct without feedback whether the delete was actually successful makes figuring out what's going wrong quite hard I've also added the http response to DeletedImage

@coveralls
Copy link

coveralls commented Jul 19, 2019

Coverage Status

Coverage increased (+0.5%) to 85.616% when pulling c0b3f8f on dino-keskic:master into 2d37b91 on smeevil:master.

@smeevil
Copy link
Owner

smeevil commented Feb 27, 2020

Hi,

Sorry for the absurd long response time :/
Today I went through the open pull request but in reversed order, this resulted in a conflict.

If you like to resolve those, I'll make sure it will be merged in this time ;)

@tonnenpinguin
Copy link
Contributor Author

Closing this in favour of #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants