fix: type error for ref on Form component
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoichiKiyokawa
changed the title
Form component and add test about refForm component and add test about ref
KoichiKiyokawa
force-pushed
the
fix/form-ref
branch
from
35287bf
to
77548a1
Compare
|
https://github.com/smeijer/next-runtime/actions/runs/1686452172 Could anyone re-run CI? |
|
They now pass :) Thanks! I'll look at your changes, and publish a new version during the weekend. |
smeijer
changed the title
Form component and add test about refref on Form component
|
@all-contributors please add @KoichiKiyokawa for code, test |
|
I've put up a pull request to add @KoichiKiyokawa! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #46
I fixed the cast in
Formcomponent. (I'm not sure if this is a good way.)Feel free to edit my code.