Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default export #6

Merged
merged 2 commits into from Mar 13, 2024
Merged

fix: remove default export #6

merged 2 commits into from Mar 13, 2024

Conversation

smeijer
Copy link
Owner

@smeijer smeijer commented Mar 13, 2024

Given that we used named and default exports together, consumers of our bundle might have run into issues as described in #5. This PR removes the default export from the codebase. Consumers need to switch to named imports instead, if they haven't already.

- import useSpinDelay from 'spin-delay';
+ import { useSpinDelay } from 'spin-delay';

@smeijer smeijer changed the title fix: also remove default export from source fix: remove default export Mar 13, 2024
@smeijer smeijer merged commit 3d4f4d5 into main Mar 13, 2024
@smeijer smeijer deleted the feature/fix-export branch March 13, 2024 18:48
@smeijer smeijer mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant