This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Stop fresh builds from failing (#81)
* chore: Reenable package-lock.json We really need some kind of lock for this (looks like we're aligning on npm anyway), since master is currently completely unable to be compiled due to lots of minor patches that have bitrotted the codebase. I'm now going to try and fix all the issues so this is a standard, compiling state to actually work from. * fix: Correct the unknown error issues Using instanceof since we know what the thrown error should be. * fix: Tests now pass as expected * fix: Lowest version we support is v14.0 While this is possibly controversial, v12 goes EOL in about a month, so might as well set v14 as the baseline, which makes our lives a little bit easier. * feat: Use npm ci instead of npm i Since we have a package-lock.json, we can download the dependencies much faster with ci. * feat: Hopefully improve cache performance Done based on https://www.voorhoede.nl/en/blog/super-fast-npm-install-on-github-actions/#fn1 * chore: update package-lock.json * chore: remove type cast * chore: rename variable to be more descriptive * ci: ensure postinstall is run for patch-package * ci: revert to state from main Co-authored-by: Nathan Smyth <nathan.smyth@mongodb.com> Co-authored-by: Stephan Meijer <stephan.meijer@gmail.com>
- Loading branch information
1 parent
21ac25e
commit b81ce0b
Showing
4 changed files
with
25 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,5 +87,8 @@ | |
"hooks": { | ||
"pre-commit": "lint-staged" | ||
} | ||
}, | ||
"engines": { | ||
"node": ">=14.0.0" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters