Merge new changes from paltas main branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
smericks
commented
Sep 6, 2023
smericks
commented
- Resolve some merge conflicts & accept new changes
The 'self' argument is included in the caching calculation, and the cache is kept globally with the class (not with each instance, as you might expect). One of these even has an unbound size! Finally, these don't actually provide an appreciable speedup.
Remove lru_cache on LOS methods
Images double in size following mag_cut failure
Argument is that generator does not need it so user should not have to suffer its installation...
Fixing deprecation issues causing test errors
…thub.com:drphilmarshall/paltas into drphilmarshall/feature/contributor-documentation
…tributor-documentation Contributor documentation
smericks
commented
Sep 6, 2023
There was a problem hiding this comment.
note bug with MagnificationError and _draw_image_standard() in drizzle function might need to be changed with my updated handling of errors
smericks
commented
Sep 6, 2023
There was a problem hiding this comment.
note kwargs_synthesis in main_deflectors line 66, 133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.