Refactor/logging #495
Refactor/logging #495
Conversation
…logging # Conflicts: # rpgJavaInterpreter-core/src/test/kotlin/com/smeup/rpgparser/execution/RunnerTest.kt
dom-apuliasoft
requested review from
lanarimarco,
benetti-smeup,
mattiabonardi,
FiorenzaBusi and
cosentino-smeup
as code owners
There was a problem hiding this comment.
First of all, great work!!!
Please update logging.md document. We have a new channel, the log format has changed, and so on.
Add Kotlin docs for all new classes/interfaces defined.
In the PR comment, provide an overview of the relationships among the new classes in order to help the reader understand what happens under the hood when Jariko logs something.
Next time, change the code format only in cases of objectively incorrect formatting. For instance, I see that you prefer placing statements on multiple lines, whereas I prefer placing them on a single line unless the line exceeds 80 characters. You can use your preferred code format for the new code, but changing the code format for code not affected by your changes makes it more difficult for me to review the code.
rpgJavaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/execution/MainExecutionContext.kt
Outdated
Show resolved
Hide resolved
rpgJavaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/execution/MainExecutionContext.kt
Outdated
Show resolved
Hide resolved
rpgJavaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/logging/loggable.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Add Kotlin docs for all new classes/interfaces defined.
It misses
In the PR comment, provide an overview of the relationships among the new classes in order to help the reader understand what happens under the hood when Jariko logs something.
It misses
And other stuff in logging.md
Description
Complete remake of the logging system
Checklist:
./gradlew ktlintCheck)./gradlew check)docsdirectory