-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/LS24002645/LIKE to file field with utilization of DS #517
Merged
lanarimarco
merged 12 commits into
develop
from
bugfix/LS24002645/like-to-file-field-with-utilization-of-ds
May 22, 2024
Merged
Bugfix/LS24002645/LIKE to file field with utilization of DS #517
lanarimarco
merged 12 commits into
develop
from
bugfix/LS24002645/like-to-file-field-with-utilization-of-ds
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat implements its methods. `MULANGTLDbMock` is an example, with own creation and populating of DB.
…lumn names for DB .
davidepalladino-apuliasoft
requested review from
lanarimarco,
benetti-smeup,
mattiabonardi,
FiorenzaBusi and
cosentino-smeup
as code owners
May 14, 2024 07:14
lanarimarco
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions
...Interpreter-core/src/main/kotlin/com/smeup/rpgparser/interpreter/compile_time_interpreter.kt
Outdated
Show resolved
Hide resolved
...Interpreter-core/src/main/kotlin/com/smeup/rpgparser/interpreter/compile_time_interpreter.kt
Show resolved
Hide resolved
lanarimarco
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
…-utilization-of-ds
lanarimarco
deleted the
bugfix/LS24002645/like-to-file-field-with-utilization-of-ds
branch
May 22, 2024 07:43
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To achieve the goal, I took from #278 and #280 branches, with Cherry Pick`, several implementations for:
LIKE
to field of file (from 280);So, the test was adapted by using
MULANGTL
insteadAUTOOG1L
, to avoid special char for columns names.Checklist:
./gradlew ktlintCheck
)./gradlew check
)docs
directory