Feature/ls24003257/data struct inz hival #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom-apuliasoft
requested review from
lanarimarco,
benetti-smeup,
mattiabonardi,
FiorenzaBusi and
cosentino-smeup
as code owners
lanarimarco
requested changes
Jul 9, 2024
There was a problem hiding this comment.
In the meantime, while we are waiting for a contribution from the RPGLE developer about improving the tests, I would ask you for some small changes. In general, I prefer to expose as little as possible of Jariko, so I am safer regarding breaking changes. Therefore, the default visibility of new functions and classes should be internal.
rpgJavaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/interpreter/values.kt
Outdated
Show resolved
Hide resolved
rpgJavaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/interpreter/values.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
INZ(*HIVAL)when applied toDataStructValues.Related to:
Checklist:
./gradlew ktlintCheck)./gradlew check)docsdirectory