Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc_connection_limits per server shard needs to be split between smp::count #11

Closed
emaxerrno opened this issue Aug 13, 2016 · 2 comments
Closed

rpc_connection_limits per server shard needs to be split between smp::count #11

emaxerrno opened this issue Aug 13, 2016 · 2 comments
Assignees
@emaxerrno
Labels
bug
Milestone
1.0

Comments

@emaxerrno
Copy link
Collaborator

the rpc_server.h

has a member var (rpc_limits)

these limits on mem need to be divided by the smp::count
@emaxerrno
Copy link
Collaborator Author

already fixed in master:

see class rpc connection limits.

@emaxerrno
Copy link
Collaborator Author

not true, memory() is already per core.

@emaxerrno emaxerrno modified the milestone: 1.0 Feb 1, 2017
@emaxerrno emaxerrno self-assigned this Feb 1, 2017
@emaxerrno emaxerrno added the bug label Feb 1, 2017
@emaxerrno emaxerrno modified the milestone: 1.0 Feb 12, 2017
dotnwat added a commit to dotnwat/smf that referenced this issue Feb 11, 2019
@dotnwat
wip-working-ish
f39d453 
[nwatkins@smash smf-ng2]$ nice -n 19 ctest
Test project /home/nwatkins/src/smf-ng2
      Start  1: smf_checksum_benchmark_test
 1/11 Test  smfrpc#1: smf_checksum_benchmark_test ......................   Passed    7.66 sec
      Start  2: smf_fbsalloc_benchmark_test
 2/11 Test  smfrpc#2: smf_fbsalloc_benchmark_test ......................   Passed   45.59 sec
      Start  3: smf_histograms_integration_test
 3/11 Test  smfrpc#3: smf_histograms_integration_test ..................   Passed    0.18 sec
      Start  4: smf_rpc_integration_test
 4/11 Test  smfrpc#4: smf_rpc_integration_test .........................***Failed    4.60 sec
      Start  5: smf_rpc_recv_timeout_integration_test
 5/11 Test  smfrpc#5: smf_rpc_recv_timeout_integration_test ............   Passed    0.24 sec
      Start  6: smf_rpc_multiple_remote_addrs_integration_test
 6/11 Test  smfrpc#6: smf_rpc_multiple_remote_addrs_integration_test ...   Passed    0.19 sec
      Start  7: smf_rpc_backpressure_integration_test
 7/11 Test  smfrpc#7: smf_rpc_backpressure_integration_test ............***Failed   12.88 sec
      Start  8: smf_rpc_send_client_timeout_integration_test
 8/11 Test  smfrpc#8: smf_rpc_send_client_timeout_integration_test .....***Failed   32.02 sec
      Start  9: smf_rpc_bad_msg_t_integration_test
 9/11 Test  smfrpc#9: smf_rpc_bad_msg_t_integration_test ...............   Passed    0.08 sec
      Start 10: smf_randomstr_unit_test
10/11 Test smfrpc#10: smf_randomstr_unit_test ..........................   Passed    0.08 sec
      Start 11: smf_simple_hist_unit_test
11/11 Test smfrpc#11: smf_simple_hist_unit_test ........................   Passed    0.07 sec

73% tests passed, 3 tests failed out of 11

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat added a commit to dotnwat/smf that referenced this issue Feb 11, 2019
@dotnwat
wip: cmake ng
aa82c15 
[nwatkins@smash smf-ng2]$ nice -n 19 ctest
Test project /home/nwatkins/src/smf-ng2
      Start  1: smf_checksum_benchmark_test
 1/11 Test  smfrpc#1: smf_checksum_benchmark_test ......................   Passed    7.66 sec
      Start  2: smf_fbsalloc_benchmark_test
 2/11 Test  smfrpc#2: smf_fbsalloc_benchmark_test ......................   Passed   45.59 sec
      Start  3: smf_histograms_integration_test
 3/11 Test  smfrpc#3: smf_histograms_integration_test ..................   Passed    0.18 sec
      Start  4: smf_rpc_integration_test
 4/11 Test  smfrpc#4: smf_rpc_integration_test .........................***Failed    4.60 sec
      Start  5: smf_rpc_recv_timeout_integration_test
 5/11 Test  smfrpc#5: smf_rpc_recv_timeout_integration_test ............   Passed    0.24 sec
      Start  6: smf_rpc_multiple_remote_addrs_integration_test
 6/11 Test  smfrpc#6: smf_rpc_multiple_remote_addrs_integration_test ...   Passed    0.19 sec
      Start  7: smf_rpc_backpressure_integration_test
 7/11 Test  smfrpc#7: smf_rpc_backpressure_integration_test ............***Failed   12.88 sec
      Start  8: smf_rpc_send_client_timeout_integration_test
 8/11 Test  smfrpc#8: smf_rpc_send_client_timeout_integration_test .....***Failed   32.02 sec
      Start  9: smf_rpc_bad_msg_t_integration_test
 9/11 Test  smfrpc#9: smf_rpc_bad_msg_t_integration_test ...............   Passed    0.08 sec
      Start 10: smf_randomstr_unit_test
10/11 Test smfrpc#10: smf_randomstr_unit_test ..........................   Passed    0.08 sec
      Start 11: smf_simple_hist_unit_test
11/11 Test smfrpc#11: smf_simple_hist_unit_test ........................   Passed    0.07 sec

73% tests passed, 3 tests failed out of 11

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat added a commit to dotnwat/smf that referenced this issue Feb 11, 2019
@dotnwat
wip: cmake ng
42d4b7e 
[nwatkins@smash smf-ng2]$ nice -n 19 ctest
Test project /home/nwatkins/src/smf-ng2
      Start  1: smf_checksum_benchmark_test
 1/11 Test  smfrpc#1: smf_checksum_benchmark_test ......................   Passed    7.66 sec
      Start  2: smf_fbsalloc_benchmark_test
 2/11 Test  smfrpc#2: smf_fbsalloc_benchmark_test ......................   Passed   45.59 sec
      Start  3: smf_histograms_integration_test
 3/11 Test  smfrpc#3: smf_histograms_integration_test ..................   Passed    0.18 sec
      Start  4: smf_rpc_integration_test
 4/11 Test  smfrpc#4: smf_rpc_integration_test .........................***Failed    4.60 sec
      Start  5: smf_rpc_recv_timeout_integration_test
 5/11 Test  smfrpc#5: smf_rpc_recv_timeout_integration_test ............   Passed    0.24 sec
      Start  6: smf_rpc_multiple_remote_addrs_integration_test
 6/11 Test  smfrpc#6: smf_rpc_multiple_remote_addrs_integration_test ...   Passed    0.19 sec
      Start  7: smf_rpc_backpressure_integration_test
 7/11 Test  smfrpc#7: smf_rpc_backpressure_integration_test ............***Failed   12.88 sec
      Start  8: smf_rpc_send_client_timeout_integration_test
 8/11 Test  smfrpc#8: smf_rpc_send_client_timeout_integration_test .....***Failed   32.02 sec
      Start  9: smf_rpc_bad_msg_t_integration_test
 9/11 Test  smfrpc#9: smf_rpc_bad_msg_t_integration_test ...............   Passed    0.08 sec
      Start 10: smf_randomstr_unit_test
10/11 Test smfrpc#10: smf_randomstr_unit_test ..........................   Passed    0.08 sec
      Start 11: smf_simple_hist_unit_test
11/11 Test smfrpc#11: smf_simple_hist_unit_test ........................   Passed    0.07 sec

73% tests passed, 3 tests failed out of 11

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat added a commit to dotnwat/smf that referenced this issue Feb 11, 2019
@dotnwat
wip: cmake ng
3a61a05 
[nwatkins@smash smf-ng2]$ nice -n 19 ctest
Test project /home/nwatkins/src/smf-ng2
      Start  1: smf_checksum_benchmark_test
 1/11 Test  smfrpc#1: smf_checksum_benchmark_test ......................   Passed    7.66 sec
      Start  2: smf_fbsalloc_benchmark_test
 2/11 Test  smfrpc#2: smf_fbsalloc_benchmark_test ......................   Passed   45.59 sec
      Start  3: smf_histograms_integration_test
 3/11 Test  smfrpc#3: smf_histograms_integration_test ..................   Passed    0.18 sec
      Start  4: smf_rpc_integration_test
 4/11 Test  smfrpc#4: smf_rpc_integration_test .........................***Failed    4.60 sec
      Start  5: smf_rpc_recv_timeout_integration_test
 5/11 Test  smfrpc#5: smf_rpc_recv_timeout_integration_test ............   Passed    0.24 sec
      Start  6: smf_rpc_multiple_remote_addrs_integration_test
 6/11 Test  smfrpc#6: smf_rpc_multiple_remote_addrs_integration_test ...   Passed    0.19 sec
      Start  7: smf_rpc_backpressure_integration_test
 7/11 Test  smfrpc#7: smf_rpc_backpressure_integration_test ............***Failed   12.88 sec
      Start  8: smf_rpc_send_client_timeout_integration_test
 8/11 Test  smfrpc#8: smf_rpc_send_client_timeout_integration_test .....***Failed   32.02 sec
      Start  9: smf_rpc_bad_msg_t_integration_test
 9/11 Test  smfrpc#9: smf_rpc_bad_msg_t_integration_test ...............   Passed    0.08 sec
      Start 10: smf_randomstr_unit_test
10/11 Test smfrpc#10: smf_randomstr_unit_test ..........................   Passed    0.08 sec
      Start 11: smf_simple_hist_unit_test
11/11 Test smfrpc#11: smf_simple_hist_unit_test ........................   Passed    0.07 sec

73% tests passed, 3 tests failed out of 11

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emaxerrno emaxerrno

Labels
bug
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@emaxerrno