fix: disable linter warning for tests #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdzicMilos
reviewed
Sep 27, 2023
src/index.js
Outdated
| @@ -35,6 +35,12 @@ module.exports = { | |||
| 'sonarjs/no-duplicate-string': 'off', | |||
| }, | |||
| }, | |||
| { | |||
| files: ['**/__tests__/**/*.[jt]s?(x)', '**/?(*.)+(spec|test).[tj]s?(x)*'], | |||
There was a problem hiding this comment.
I would add this bellow line 35, as part of ignore of group of files.
AdzicMilos
reviewed
Sep 27, 2023
src/index.js
Outdated
| { | ||
| files: ['**/__tests__/**/*.[jt]s?(x)', '**/?(*.)+(spec|test).[tj]s?(x)*'], | ||
| rules: { | ||
| 'import/no-named-as-default': 0, |
There was a problem hiding this comment.
We can add 'off' to be consistent
AdzicMilos
approved these changes
Sep 27, 2023
|
🎉 This PR is included in version 4.0.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References JIRA ticket
Motivation and context
Linter is showing warnings for tests 3rd party package
@testing-library/user-event. Instead ofdefaultexport of the module, this package exports a named export calleddefault.Before
Running linter shows warnings for test files:
warning Using exported name 'userEvent' as identifier for default export import/no-named-as-default.After
Running linter doesn't show
import/no-named-as-defaultwarnings for test files.How to test
Affected repos: seller-web, listings-web, next-example, components-pkg.
Run linter and confirm warnings are showing up. As change is a small one, you might apply it directly and re-run the linter. After the PR merge and
eslint-config-pkgversion bump, re-test all the affected repos.