Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: String streaming (w/ separate JSON string reader cls) #91

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smheidrich
Copy link
Owner

@smheidrich smheidrich commented Aug 24, 2023

2nd attempt at something that looks more like how it's done in json-stream, i.e. with a separate JSON string reader class.

Equivalent of daggaz/json-stream#47 on json-stream side.

Supersedes #84 and #89.

ToDos:

  • Change string handling in RustTokenizer
  • JsonStringReader impl.
  • Tests
    • Using json-stream's (with some xfail where not important)
    • Our own (integration tests)

Allows json-stream's JsonStringReader unit tests to work for us, too.
@smheidrich smheidrich force-pushed the string-streaming-via-sep-string-parser-struct-attempt2 branch from 0125b92 to ec680c9 Compare August 25, 2023 11:17
@smheidrich
Copy link
Owner Author

@daggaz Just to let you know: I think the most important features here are finally ready (namely, returning strings as objects that can be read() from and iterated over, if requested via strings_as_files=True) and I'm not sure the other ones (full IOBase interface implementation, exactly aligning exceptions with the Python tokenizer, etc.) are required at this point.

So I'm prepared to merge this when you are 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant