Skip to content

Commit

Permalink
allows tsc to fail in ci tests
Browse files Browse the repository at this point in the history
  • Loading branch information
erikyo committed May 12, 2024
1 parent 7dc97d7 commit 42498d6
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
21 changes: 15 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,25 @@ on:
- push
- pull_request
jobs:
build:
name: Build with tsc
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: lts/*
cache: 'npm'
- run: npm ci
- run: npx tsc
test:
name: Node.js ${{ matrix.node-version }} on ${{ matrix.os }}
name: Test ${{ matrix.node-version }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
node-version:
- 18
- 20
node: [ 18, 20 ]
os:
- ubuntu-latest
- windows-latest
Expand All @@ -20,6 +30,5 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npx tsc
- run: npm ci
- run: npm test
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"allowJs": true,

// Check js files for errors
"checkJs": false,
"checkJs": true,

// the directory sources are in
"rootDir": "src",
Expand Down

0 comments on commit 42498d6

Please sign in to comment.