Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for big endian mo files #97

Open
johnhooks opened this issue May 12, 2024 · 0 comments
Open

Tests for big endian mo files #97

johnhooks opened this issue May 12, 2024 · 0 comments

Comments

@johnhooks
Copy link

Problem

The package has support for handling both big and little endian byte order, though only little endian is being tested.

Solution

Add test and fixtures for big endian mo files.

johnhooks added a commit to johnhooks/gettext-parser that referenced this issue May 13, 2024
This commit adds support for compiling big-endian .mo files. This
facilitates the use of .mo files in big-endian systems, the ability
to parser big-endian .mo files was already present.

This commit also does the following:

- Adds tests and fixtures for big-endian .mo files.
- Rename the existing .mo fixtures to indicate that they are
  little-endian.

Fixes smhg#97
johnhooks added a commit to johnhooks/gettext-parser that referenced this issue May 13, 2024
This commit adds support for compiling big-endian .mo files. This
facilitates the use of .mo files in big-endian systems, the ability
to parser big-endian .mo files was already present.

This commit also does the following:

- Adds tests and fixtures for big-endian .mo files.
- Rename the existing .mo fixtures to indicate that they are
  little-endian.

Fixes smhg#97
johnhooks added a commit to johnhooks/gettext-parser that referenced this issue May 13, 2024
This commit adds support for compiling big-endian .mo files. This facilitates
the use of .mo files in big-endian systems, the ability to parser big-endian
.mo files was already present.

This commit also does the following:

- Adds a new mo parser options type, used to indicate `endian = 'le' | 'be'`
- Adds tests and fixtures for big-endian .mo files.
- Renames the existing .mo fixtures to indicate that they are little-endian.
- Fixes direct usages of `writeUInt32LE`.

Fixes smhg#97
johnhooks added a commit to johnhooks/gettext-parser that referenced this issue May 13, 2024
This commit adds support for compiling big-endian .mo files. This facilitates
the use of .mo files in big-endian systems, the ability to parser big-endian
.mo files was already present.

This commit also does the following:

- Adds a new mo parser options type, used to indicate `endian = 'le' | 'be'`
- Adds tests and fixtures for big-endian .mo files.
- Renames the existing .mo fixtures to indicate that they are little-endian.
- Fixes direct usages of `writeUInt32LE`.

Fixes smhg#97
johnhooks added a commit to wp-blocks/gettext-parser that referenced this issue May 27, 2024
* feat: add support for compiling big-endian .mo files

This commit adds support for compiling big-endian .mo files. This facilitates
the use of .mo files in big-endian systems, the ability to parser big-endian
.mo files was already present.

This commit also does the following:

- Adds a new mo parser options type, used to indicate `endian = 'le' | 'be'`
- Adds tests and fixtures for big-endian .mo files.
- Renames the existing .mo fixtures to indicate that they are little-endian.
- Fixes direct usages of `writeUInt32LE`.

Fixes smhg#97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant