Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threaded dnsresolve module #1535

Conversation

TheTechromancer
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #1535 (152464e) into master (f2a3acd) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1535   +/-   ##
=======================================
  Coverage   53.69%   53.70%           
=======================================
  Files         475      475           
  Lines       39868    39875    +7     
=======================================
+ Hits        21409    21414    +5     
- Misses      18459    18461    +2     
Impacted Files Coverage Δ
modules/sfp_dnsresolve.py 39.87% <33.33%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a3acd...152464e. Read the comment docs.

Copy link
Contributor

@Omicron166 Omicron166 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit pull request, should work fine

@Omicron166
Copy link
Contributor

@smicallef this pr looks good, pls check it

@smicallef
Copy link
Owner

Similar to my sfp_commonsrv feedback, can we make the number of threads here configurable in the same way other modules do it? A default hard-coded setting of 20 is likely too high for many systems considering how threading-intensive SpiderFoot already is these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants