Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix day button not being disabled when disabled is true #115

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Fix day button not being disabled when disabled is true #115

merged 2 commits into from
Apr 17, 2018

Conversation

tomnez
Copy link
Contributor

@tomnez tomnez commented Apr 13, 2018

Forgot to add disabled attribute to the buttons in the day template, so disabled dates were appearing disabled but were still clickable 馃槼

@tomnez tomnez self-assigned this Apr 13, 2018
andrewpye
andrewpye approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible fix 馃槢 Maybe worth adding a test for this?

@tomnez
Copy link
Contributor Author

tomnez commented Apr 17, 2018

@andrewpye test added!

@tomnez tomnez merged commit 3914329 into master Apr 17, 2018
@tomnez tomnez deleted the date-picker-add-disabled-attr-to-day branch April 18, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladucu vladucu vladucu approved these changes

@andrewpye andrewpye andrewpye approved these changes

Assignees

@tomnez tomnez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomnez @vladucu @andrewpye