Update polaris-icon to v2.0.0 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomnez
approved these changes
May 11, 2018
| for (const color of colors) { | ||
| this.set('color', color); | ||
|
|
||
| const colorClass = `Polaris-Icon--color${classify(color)}`; | ||
| assert.ok(icon.classList.contains(colorClass), `icon with ${color} color applies ${colorClass} class`); | ||
| assert.equal(icon.classList.length, 3, `icon with ${color} color does not add other color classes`); | ||
|
|
||
| const colorClassNames = [...icon.classList].filter((className) => className.indexOf('Polaris-Icon--color') === 0); |
There was a problem hiding this comment.
This doesn't bug me being all on one line, but for the record if I did this, you'd have me split it up 😛
There was a problem hiding this comment.
Guess I thought that the intent of this line was more important than showing the details explicitly, but you're right, I should play by my own rules 😛
| @@ -44,19 +48,30 @@ test('it applies colors correctly', function(assert) { | |||
| 'purple' | |||
| ]; | |||
|
|
|||
| assert.expect(2 + colors.length * 3); | |||
vladucu
approved these changes
May 14, 2018
| @@ -19,15 +20,13 @@ export default Component.extend({ | |||
|
|
|||
| layout, | |||
|
|
|||
| /* | |||
| * Public attributes. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
polaris-iconto match the v2.0.0 React component by adding the internalisColoredclass (required for proper icon rendering now), and setting the newfocusableandaria-hiddenattributes on the icon's SVG element.