Use render-component to align component interfaces with React implementations
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…description properties and deprecate termComponent and descriptionComponent
…ept components as the label property
andrewpye
deleted the
enhancement/deprecate-explicit-component-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our implementations of
polaris-checkboxandpolaris-description-listhad previously had separatelabel/labelComponentproperties etc. which was out of alignment with the React implementations and a nuisance for developers to remember. With this PR, the following become deprecated:labelComponentforpolaris-checkbox;termComponentanddescriptionComponentforpolaris-description-list#items.Instead, the components can now be simply passed as
label,termanddescriptionrespectively.