Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing hidden class to polaris-label #151

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Add missing hidden class to polaris-label #151

merged 2 commits into from
Jul 3, 2018

Conversation

andrewpye
Copy link
Member

Adds the Polaris-Label--hidden class that was missing from polaris-label when hidden was truthy.

@andrewpye andrewpye self-assigned this Jul 3, 2018
@andrewpye andrewpye requested a review from vladucu July 3, 2018 09:36
@andrewpye andrewpye mentioned this pull request Jul 3, 2018
Merged
vladucu
vladucu approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@vladucu vladucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vladucu
Copy link
Member

vladucu commented Jul 3, 2018

PS: this might worth a test

@andrewpye andrewpye merged commit 9a8e743 into master Jul 3, 2018
@andrewpye andrewpye deleted the fix/missing-hidden-class-on-label branch July 3, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladucu vladucu vladucu approved these changes

Assignees

@andrewpye andrewpye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewpye @vladucu