Accept card title as a string or a component #152
Conversation
|
|
||
| await render(hbs`{{is-component-definition inputValue}}`); | ||
|
|
||
| assert.equal(this.element.textContent.trim(), '1234'); |
There was a problem hiding this comment.
This test needs updating, surely it doesn't pass?
There was a problem hiding this comment.
many tests should be updated if we want to be consistent with latest ones...though this should work well (ember always has backwards support)
| } | ||
|
|
||
| let contentConstructorName = content.constructor.name || ''; | ||
| return contentConstructorName.indexOf('ComponentDefinition') > -1; |
There was a problem hiding this comment.
Should probably update render-content to use this function to keep things DRY 👍
| @@ -3,7 +3,11 @@ | |||
| <div class="Polaris-Card__Header"> | |||
| {{#polaris-stack alignment="baseline" as |stack|}} | |||
| {{#stack.item fill=true}} | |||
| {{polaris-heading text=title}} | |||
| {{#if (is-component-definition title)}} | |||
There was a problem hiding this comment.
Hmm... this helper is a nice idea, but it will ignore the changes I made to render-content in #147 (handling content being a hash of componentName and props). We probably want to be able to support both the component definition and componentName + props hash way of doing things here, since render-content will support it...
There was a problem hiding this comment.
not really an idea...we need to not wrap title in a heading if it's passed as a component....but will check if we can support both
| @@ -62,6 +63,7 @@ export default Component.extend({ | |||
| * @property headerActions | |||
| * @type {Action[]} | |||
There was a problem hiding this comment.
This should probably get changed to Object[] now, maybe worth checking if any other @types need updating too
There was a problem hiding this comment.
will leave for when we cleanup/refactor...just cause there are many things we'd need to update here
|
@andrewpye updated, dry-ed up the |
No description provided.