Add notes about avoiding Glimmer error under dynamic usages of auto-wrapping components #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapping components
tomnez
approved these changes
Jul 10, 2018
docs/form-layout.md
Outdated
| @@ -28,3 +28,23 @@ Form layout with two groups, the second of which is condensed: | |||
| {{/formLayout.group}} | |||
| {{/polaris-form-layout}} | |||
| ``` | |||
|
|
|||
| For dynamic forms where items are added or removed once the form has rendered, you must explicitly a form layout item component around each item to prevent a Glimmer error such as `Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node`: | |||
There was a problem hiding this comment.
typo: you have "explicitly a form item" instead of "explicitly add a form item"
There was a problem hiding this comment.
😱
Good catch, thanks 😄
|
Gonna merge this down without making a release, since there are no code changes to go out and people probably read the docs online on here rather than from their app's |
andrewpye
deleted the
documentation/add-notes-about-glimmer-error-for-autowrapping-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, 4 of the components in
ember-polarisauto-wrap their child elements indivs -polaris-button-group,polaris-form-layout,polaris-form-layout/groupandpolaris-stack. If any of these components are used with dynamic contents (e.g. with anif- oreach-block inside), whenever an item is added or removed a Glimmer error can occur. Unfortunately I don't think we can detect this possibility and avoid it automatically (certainly not quickly), so I thought it was worth adding notes and examples to the docs for those components affected.