Upgrade Ember to 3.4 #168
Merged
Upgrade Ember to 3.4 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivakumar-kailasam
suggested changes
Sep 14, 2018
There was a problem hiding this comment.
Looks like there's a bunch of errors with the latest ember-template-lint rules. May be turn them off for now so that tests pass?
Also looks like we're still using ember-native-dom-helpers. if you run ember-cli-update --run-codemods there should be one which ports the imports over to 3+ ember test helpers.
andrewpye
approved these changes
Sep 14, 2018
|
thx guys! |
|
shipped and following up with a PR to fixing linting...won't spend the time to convert away from native dom now, since there's manual work involved too...we'll do that as we add/update components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge this in a main
devbranch and basing Polaris resource list on top of theseember-cliupgrade diff here