Update labelled to v2.11.0 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladucu
requested changes
Oct 22, 2018
addon/components/polaris-labelled.js
Outdated
| * @private | ||
| */ | ||
| shouldRenderError: computed('error', function() { | ||
| let { error } = this; |
There was a problem hiding this comment.
I think we still want to use Ember getters to support older versions of Ember.....from what I remember I run into issues trying to do this before
| @@ -20,12 +20,9 @@ | |||
|
|
|||
| {{yield}} | |||
|
|
|||
| {{#if error}} | |||
| {{#if shouldRenderError}} | |||
| <div id={{errorId}} class="Polaris-Labelled__Error"> | |||
There was a problem hiding this comment.
id={{errorId}} seems no longer needed here
sivakumar-kailasam
approved these changes
Oct 23, 2018
vladucu
approved these changes
Oct 23, 2018
delete-merged-branch
bot
deleted the
enhancement/update-labelled-to-v2.11.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #215
I didn't update to use
ember-test-selectorshere simply because the existing tests are just straight ports of the React implementation's tests. Let me know if you guys feel like we should make that update anyway and I'll do it 馃憤