Update page to v2.11.0 #218
Conversation
| @@ -104,4 +115,11 @@ export default Component.extend({ | |||
| hasActions: or('primaryAction', 'secondaryActions').readOnly(), | |||
| hasSecondaryActions: gt('secondaryActions.length', 0).readOnly(), | |||
| hasRollup: gt('secondaryActions.length', 1).readOnly(), | |||
|
|
|||
| shouldRenderPrimaryActionAsPrimary: computed('primaryAction.primary', function() { | |||
There was a problem hiding this comment.
Very happy to rename this if anyone can think of anything better 😉
There was a problem hiding this comment.
Yeah, it's weird that this is a thing now but 🤷♂️ I'm good with it
| @@ -104,4 +115,11 @@ export default Component.extend({ | |||
| hasActions: or('primaryAction', 'secondaryActions').readOnly(), | |||
| hasSecondaryActions: gt('secondaryActions.length', 0).readOnly(), | |||
| hasRollup: gt('secondaryActions.length', 1).readOnly(), | |||
|
|
|||
| shouldRenderPrimaryActionAsPrimary: computed('primaryAction.primary', function() { | |||
There was a problem hiding this comment.
Yeah, it's weird that this is a thing now but 🤷♂️ I'm good with it
|
@sivakumar-kailasam I wasn't going to because there aren't any tests for either of these features in the React implementation at the moment. Can add some if @vladucu / @tomnez think it's worthwhile though... |
|
Would be nice to drop in a quick test, nothing fancy, just that we render these properties correctly |
|
@sivakumar-kailasam @vladucu added a couple of tests, not run codemods on them though because it causes issues with registering the mock |
delete-merged-branch
bot
deleted the
enhancement/update-page-to-v2.11.0
branch
Closes #217 by adding
titleMetadataandprimarysupport to page header.Screen grab with
titleMetadata=(component "polaris-badge" status="success" text="Metadata")andprimaryAction=(hash primary=false ...):