Upgrade v2.11.0 date picker #219
Conversation
tomnez
force-pushed
the
upgrade-v2.11.0-date-picker
branch
from
e9e5c0d
to
974f3e3
Compare
| @@ -10,6 +11,8 @@ import { | |||
| getNextDisplayMonth, | |||
| getPreviousDisplayYear, | |||
| getPreviousDisplayMonth, | |||
| weekdays, // obj | |||
There was a problem hiding this comment.
Is the // obj comment needed here?
There was a problem hiding this comment.
Ah! That was supposed to be a temporary reminder to myself since Polaris uses enums for weekdays haha. Will remove..
| @@ -10,6 +11,8 @@ import { | |||
| getNextDisplayMonth, | |||
| getPreviousDisplayYear, | |||
| getPreviousDisplayMonth, | |||
| weekdays, // obj | |||
| isSameDay, | |||
| } from '../utils/dates'; | |||
|
|
|||
| // TODO: add changes for Polaris v2.2.0 | |||
There was a problem hiding this comment.
How 'bout these guys? Are those changes present now?
There was a problem hiding this comment.
Ah yeah this can be removed. Ironically the additions from 2.0->2.2 are stripped out in 2.11 (other than translations on accessibility labels which we don't have)
| * @type {String} | ||
| * @default 'Sunday' | ||
| */ | ||
| weekStartsOn: weekdays.Sunday, |
There was a problem hiding this comment.
This guy should probs be up with the rest of the public interface 😉
There was a problem hiding this comment.
@andrewpye Ah meant to comment on this, the linter hates these types of properties (it considers this an "unknown property type") and wants everything above it. I tried ignoring with eslint and prettier comments but it didn't seem to work. Any ideas on working around this?
There was a problem hiding this comment.
Unfortunately I don't, but maybe @sivakumar-kailasam does?
There was a problem hiding this comment.
Looks like assigning to a variable first fixes it. Kinda wack, but better than having it at the bottom all willy nilly (I think)
tomnez
force-pushed
the
upgrade-v2.11.0-date-picker
branch
from
3ade81f
to
12a916e
Compare
Diff here
Finishes #198