Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade v2.11.0 radio button #221

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Upgrade v2.11.0 radio button #221

merged 3 commits into from
Oct 23, 2018

Conversation

tomnez
Copy link
Contributor

@tomnez tomnez commented Oct 22, 2018

Diff here

Finishes #220

@tomnez tomnez self-assigned this Oct 22, 2018
andrewpye
andrewpye approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There're a couple of failing tests but they're unrelated to your changes here and are failing on a couple of my new branches too. I've put up a branch to fix those so we should be all clear once that's merged 👍

vladucu
vladucu approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@vladucu vladucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andrewpye
Copy link
Member

@tomnez merge up dev and the failing tests should be fixed 👍

@tomnez tomnez force-pushed the upgrade-v2.11.0-radio-button branch from d046cac to 0326d08 Compare October 23, 2018 13:47
@tomnez tomnez force-pushed the upgrade-v2.11.0-radio-button branch from 0326d08 to af59592 Compare October 23, 2018 20:16
@tomnez tomnez merged commit 330d071 into dev Oct 23, 2018
@delete-merged-branch delete-merged-branch bot deleted the upgrade-v2.11.0-radio-button branch October 23, 2018 20:57
@vladucu vladucu mentioned this pull request Oct 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladucu vladucu vladucu approved these changes

@andrewpye andrewpye andrewpye approved these changes

Assignees

@tomnez tomnez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomnez @andrewpye @vladucu