-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade button-group to v2.11.0 #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Tom, just a minor test simplification suggestion.
PS: you're killin it, so close 🔥
this.render(hbs`{{polaris-button-group fullWidth=fullWidth}}`); | ||
|
||
const buttonGroup = find(buttonGroupSelector); | ||
assert.ok( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not something simpler
assert.dom(buttonGroupSelector).hasClass('Polaris-ButtonGroup--fullWidth', 'fullWidth=false - does not add the fullWidth class');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh! Forgot to codemod this file..
@vladucu updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing: migrate from using ember-native-dom-helpers
provided test selectors 😇
lol @vladucu updated again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🎸
Diff here
Finishes #229