Add select component #232
Merged
Add select component #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladucu
reviewed
Oct 25, 2018
| * @default '' | ||
| * @public | ||
| */ | ||
| value: '', |
There was a problem hiding this comment.
was the intention to use PLACEHOLDER_VALUE const here?
There was a problem hiding this comment.
Yes, but I avoided doing so to stop the linter moving this to the end of the file 😬
addon/components/polaris-select.js
Outdated
| * @type {Object[]} | ||
| * @private | ||
| */ | ||
| normalizedOptions: computed(function() { |
There was a problem hiding this comment.
should this depend on options at least?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #228 by adding
polaris-select. Original component source is here.I've added a test page to the dummy app - here's a GIF of it in action:
You can compare it to the same page in React world here.