Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Ember 2.12 support #234

Merged
merged 3 commits into from
Oct 25, 2018
Merged

Drop Ember 2.12 support #234

merged 3 commits into from
Oct 25, 2018

Conversation

andrewpye
Copy link
Member

With the promotion of Ember 3.4 to LTS, addons are no longer recommended to support Ember 2.12. Dropping support for this means that we sidestep an awkward test failure in polaris-sticky tests, and can drop our custom get-array-item helper 馃檶

@andrewpye andrewpye self-assigned this Oct 25, 2018
vladucu
vladucu approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@vladucu vladucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃巻

just please clean up config/ember-try.js too

@andrewpye andrewpye merged commit 7b065f7 into dev Oct 25, 2018
@delete-merged-branch delete-merged-branch bot deleted the update/drop-ember-2.12-support branch October 25, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladucu vladucu vladucu approved these changes

@sivakumar-kailasam sivakumar-kailasam Awaiting requested review from sivakumar-kailasam

@tomnez tomnez Awaiting requested review from tomnez

Assignees

@andrewpye andrewpye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewpye @vladucu