Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade v2.11.0 action list item #236

Merged
merged 3 commits into from
Oct 25, 2018
Merged

Conversation

tomnez
Copy link
Contributor

@tomnez tomnez commented Oct 25, 2018

Diff here

Finishes #231

@tomnez tomnez self-assigned this Oct 25, 2018
@tomnez tomnez force-pushed the upgrade-v2.11.0-action-list-item branch from 9831c2c to 8c693e6 Compare October 25, 2018 15:36
Copy link
Member

@vladucu vladucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!
didn't payed too much attention to tests, trust you did as usual 💪

Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @vladucu said 😉

@tomnez tomnez merged commit 83ddb4a into dev Oct 25, 2018
@delete-merged-branch delete-merged-branch bot deleted the upgrade-v2.11.0-action-list-item branch October 25, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants