Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action item actions event bubbling #237

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Conversation

tomnez
Copy link
Contributor

@tomnez tomnez commented Oct 25, 2018

Fix for #162

@tomnez tomnez self-assigned this Oct 25, 2018
@tomnez
Copy link
Contributor Author

tomnez commented Oct 25, 2018

Added this to dev since we're closing in on the v2.11.0 branch, I figure it can be a part of that release rather than go through a release cycle for this fix and then another one a couple days later after v2.11.0.

Let me know if anyone thinks I should repurpose this to go straight to master for a quick bugfix release instead.

Copy link
Member

@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a test for this? 🤔

Also thinking that theoretically we should release this independent of the Polaris 2.11.0 update so we don't force users to update just for a small bugfix... but then again I don't know if we currently have any users 😅

@vladucu
Copy link
Member

vladucu commented Oct 26, 2018

I think we can likely follow Ember suite and port this to the next 1.x+ version if anybody needs it...no biggie

@vladucu
Copy link
Member

vladucu commented Oct 26, 2018

but yeah, a test would be nice

@tomnez tomnez force-pushed the bugfix/action-list-item-actions branch from 8c2db13 to 2b02538 Compare October 26, 2018 16:45
@tomnez
Copy link
Contributor Author

tomnez commented Oct 26, 2018

@vladucu added a test and resolved conflicts, will merge once it passes 🕺

@tomnez tomnez merged commit 713f730 into dev Oct 26, 2018
@delete-merged-branch delete-merged-branch bot deleted the bugfix/action-list-item-actions branch October 26, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants