Use children vs. childNodes in data-table cell height calc #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete-merged-branch
bot
deleted the
fix-data-table-height-calculation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved this fix out of #243 to be in it's own PR since we're going to hold off on merging #243 until we upgrade to a version of Polaris where they include the fix as well.
Copied description from 243:
As for the heights not calculating correctly, we were using
childNodeswhich was also grabbing text nodes, whereas we want just html elements. The React version gets away with usingchildNodesbecause they userow.childNodes as NodeListOf<HTMLElement>so I'm guessing this is a TS thing where it will only grab elements and filter out the text nodes.