Add option list component #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomnez
approved these changes
Jan 25, 2019
|
|
||
| /** | ||
| * Sections containing a header and related options | ||
| * Available properties: |
There was a problem hiding this comment.
Noice descriptions on these 💯
|
|
||
| /** | ||
| * Polaris option list component. | ||
| * See https://polaris.shopify.com/components/lists-and-tables/option-list |
There was a problem hiding this comment.
Do we still need this here since we now have individual docs with the links per component? No biggie though. Just a thought.
There was a problem hiding this comment.
This is in the majority of our other components, I don't see any harm having an extra link directly in the source code ¯\_(ツ)_/¯
delete-merged-branch
bot
deleted the
feature/add-option-list-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a port of the React
OptionListcomponent. This is based on the source for the version of Polaris that we're currently targeting inember-polaris(i.e. v2.11.0).