New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing a component as polaris-choice-list's helpText property #280

Merged

andrewpye merged 2 commits into master from enhancement/support-component-as-choice-help-text

Feb 22, 2019

Member

andrewpye commented Feb 22, 2019 •

edited

This is supported by the React implementation, so we should probably support it too 😉


          Allow passing a component as polaris-choice-list's helpText property

49a5f54

andrewpye self-assigned this

andrewpye requested review from vladucu and tomnez

February 22, 2019 11:47


          Add changelog entry

58a7f14

vladucu approved these changes

View reviewed changes

andrewpye merged commit 4f1367f into master

delete-merged-branch bot deleted the enhancement/support-component-as-choice-help-text branch

February 22, 2019 12:17

Member Author

andrewpye commented Feb 22, 2019

Move ember-smile-polaris customisations to ember-polaris-internal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment