Handle non-numeric progress values in progress bar #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladucu
approved these changes
Feb 22, 2019
delete-merged-branch
bot
deleted the
fix/handle-non-numeric-values-in-progress-bar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the React Polaris components use TypeScript, their
ProgressBarcomponent handles non-numeric values quite cleanly. Our implementation unfortunately did not, so in this PR I've updated its behaviour to match the Shopify version's:progressvalues result in the bar being rendered without avalueattribute, making it appear empty;