Break infinite loop in sticky manager

[andrewpye]

Noticed today while testing polaris-sticky in one of our apps that the manageStickyItems method in sticky-manager has an infinite loop, figured I should probably fix it 🤦‍♂️

[vladucu]

It seems by default Polaris's throttle will have the func invoked on the trailing edge of the timeout only if the throttled function is invoked more than once during the wait timeout while Ember's throttle will trigger the function on the leading instead of the trailing edge of the wait interval

Do you think using throttle with immediate false would do the same? if yes maybe we can get rid of the debounceTask call altogether....but maybe I'm missing something

PS: seems Polaris uses 40 as the timeout instead of 50 for the throttles

[andrewpye]

It seems by default Polaris's throttle will have the func invoked on the trailing edge of the timeout only if the throttled function is invoked more than once during the wait timeout

Not quite, from what I can see - this is only if both leading: true and trailing: true are specified. The default behaviour seems to be trailing.

Do you think using throttle with immediate false would do the same?

I'll try this, you might be onto something 👍

PS: seems Polaris uses 40 as the timeout instead of 50 for the throttles

Nowadays yes, but not on v2.11.0 which we currently mimic...

[andrewpye]

@vladucu updated (and now the diff's best viewed with whitespace diffing disabled)