Update action list to v3.10.0 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpye
commented
Mar 19, 2019
| * - badge (not currently supported) | ||
| * - onAction | ||
| * | ||
| * @property item |
There was a problem hiding this comment.
Needed to remove this and pass individual properties through to support the new role property passed in from polaris-action-list/section
tomnez
reviewed
Mar 21, 2019
| items=(array | ||
| (hash | ||
| text="I'm helpful" | ||
| helpText="Yay I'm helping!" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
polaris-action-listand child components to match Polaris v3.10.0. I haven't added the new scroll functionality since we don't currently need it anywhere and don't have an implementation of the PolarisScrollablecomponent that we'd need for it anyway.