Update avatar to Polaris v3.10.0 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladucu
approved these changes
Mar 20, 2019
| class="Polaris-Avatar__Image" | ||
| src={{finalSource}} | ||
| alt="" | ||
| role="presentation" | ||
| onload={{action "handleLoad"}} |
There was a problem hiding this comment.
just double-checking these are the right events here in Ember world
There was a problem hiding this comment.
Well, I initially went with {{action "handleLoad" on="load"}} element modifiers and tried tinkering with that, but apparently that approach doesn't work here so this is what I landed on. The updated tests cover this functionality and with the exception of a timing issue in the tests for Ember 2.16/2.18, they pass without problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
polaris-avatarto match Polaris v3.10.0. I haven't added the newisServerfunctionality since we don't need it at this point. Also dropped the old tests in favour of porting the new ones added inpolaris-reactsince we initially builtpolaris-avatar.