Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update date picker to Polaris v3.10.0 #298

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

andrewpye
Copy link
Member

Tweaks the logic on polaris-date-picker's inHoveringRange to match the React implementation.

@andrewpye andrewpye self-assigned this Mar 26, 2019
@andrewpye
Copy link
Member Author

Copy link
Member

@vladucu vladucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here looks good....a bit hard to follow, since we departed from the original implementation a bit

@andrewpye
Copy link
Member Author

a bit hard to follow, since we departed from the original implementation a bit

Agreed, this is one of the reasons I've been so keen to port the React implementations as closely as possible even when it's not necessarily needed...

@andrewpye andrewpye merged commit a56feac into update/polaris-v3.10.0 Mar 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the update/date-picker-v3.10.0 branch March 26, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants