Update link to Polaris v3.10.0 #304
Conversation
| @@ -92,6 +92,25 @@ test('it renders the correct HTML with external attribute', function(assert) { | |||
| ); | |||
| }); | |||
|
|
|||
| test('it renders the correct HTML with monochrome attribute', function(assert) { | |||
| this.render(hbs` | |||
There was a problem hiding this comment.
would it be too much to ask to convert the test to new syntax? 😬
we can leave for later too, but would be nice to do it while here
There was a problem hiding this comment.
I'd prefer to get the update done in one go as quickly as possible so we can start using it, and update tests en masse in the future - they're separate changes in my mind.
There was a problem hiding this comment.
as you think it's best (anything needed for the rush?)
from my experience, that en masse = never lmao
There was a problem hiding this comment.
anything needed for the rush?
Updating the Polaris version takes a long time and we'll almost certainly have other projects coming up which will divert resources away from the update, and potentially add new parts of our apps that need updating. Test syntax updates can be done either in bulk or on an individual file basis moving forward so they're less "intrusive" changes, and don't really add any value as they're more of a "sideways" move. Getting the update out and in use seems like the more pressing change at this point 🤷♂️
There was a problem hiding this comment.
good with me
though, again, that's the reason we kicked of this update.... nothing should be pressing
There was a problem hiding this comment.
Maybe my wording oversold the urgency of this 😂 But I still feel like a better approach is to get the code changes required for the Polaris update out of the way first in one go, then make further updates as and when we have the cycles to spare 🙏
Adds support for
monochromepolaris-links and ensures the correcttypeis used when link buttons are rendered.